Well it seems to me like what Grif said still stands.
Grif wrote:
it's because there aren't proper pointer death checks
You have to be careful with these references (or pointers if you want to call them that):
Line 2: self.targetpaintergood = CreateAEmitter("Target Painter Good");
Line 9: self.beamparticle = CreateAEmitter("Particle Auto Mortar");
Line 25: self.parent = ToActor(actor);
Line 26: self.parentgun = ToHDFirearm(gun);
(btw, why are you doing ToActor again on line 27 after you just did it on line 25?) Line 27: self.angle = ToActor(self.parent):GetAimAngle(true);. It's not needed.
Also, I'd suggest that you make variable gun on Line 20 local, like this: local gun = MovableMan:GetMOFromID(i);
Same for actor on line 23. (Unless you need to use these outside of the script)
The errors (most likely, unless you make sure outside of the script that they are not destroyed.):
Line 49: self.Pos = self.parentgun.MuzzlePos;
Line 62: ... self.parentgun.ID ...
Line 65: self.targetpaintergood.Pos = ...
Line 76: self.beamparticle.Vel = ...
Line 77: self.beamparticle.Pos = ...
On line 37 you have done some checks but there are some flaws:
First, I'm not sure if this is adequate: self.parentgun == nil or self.parentgun.ID == 255. If i remember correctly, even though the object is destroyed in game, you can still read non-nil values from the pointer (the game does not set the memory to 0 where the pointer points to), so you will need some function through which the game can tell you if it has destroyed the object or not). And even if you can read from the pointer, it is illegal to read from deallocated memory. (Can crash or if not then your script might be working with invalid data) (If I'm wrong, somebody correct this). I guess MovableMan:IsDevice() will work for devices. Not sure what to use with emitters though...
EDIT:
Grif wrote:
IsParticle, if it's an unparent emitter.
Second flaw is that even though you do self.ToDelete = true; on line 40, the script still contines to run to the end before it's destroyed. You must extend the check to whole script, or alternatively return; from function. But I'd suggest enclosing all parts where you use parentgun or parent, inside the if check. Do that and add checks for the error parts too and it should work.
Also, about Agetimer on Line 7: self.Agetimer = Timer();... You don't need that, you can use the already existing Age property like Grif said:
Grif wrote:
...self.Age:IsPastSimMS...
However, I'm not sure if you can use methods on properties of objects, or if MovableObjects inherit the IsPastSimMS method from their parent class. Anyway, it would make sense that
Code:
self.Age > self.maxtime
I hope this covers most of it and that I'm not horribly wrong. But if I am, feel free to correct any of this. (Darn long post
)